Glasgow | May-2025 | Salah Ahmed| Sprint-3 #634
Conversation
…and error handling
…lue for unknown angles
avatarit
added
📅 Sprint 3
jenny-alexander
added
Review in progress
.vscode/extensions.json
Outdated
There was a problem hiding this comment.
Can you remove this file from your PR? It may have been added by mistake. Once your PR has been created, it's a good habit to review the files and ensure that only the required files are included! :)
|
|
||
| // Case 4: Identify Straight Angles: | ||
| // When the angle is exactly 180 degrees, | ||
| // Then the function should return "Straight angle" | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
| const Straight = getAngleType(180); |
There was a problem hiding this comment.
It's good practice to name your variables, functions and with a camelCase.
const straight
Further reading: https://dev.to/hassanzohdy/best-practices-for-case-styles-camel-pascal-snake-and-kebab-case-in-node-and-javascript-55oi
There was a problem hiding this comment.
I have changed the names of variables
jenny-alexander
added
Reviewed
… add case for unknown angles
…ero denominator case
… cases for accuracy and coverage
…dinalNumber function
…negative count handling
…rresponding test case
There was a problem hiding this comment.
@avatarit The changes you made are good and you're on the right track. 👍
I added a few comments of a few things I noticed while re-reviewing it.
Also, please remove the package-lock.json and package.json files from the PR as they shouldn't be included in the PR.
jenny-alexander
removed
the
Needs Review
There was a problem hiding this comment.
I think there might be a bit of confusion regarding the package.json and package-lock.json files.
When I asked you to remove them from the PR, it seems you may have thought I asked you to "remove" the file from the project completely.
The file needs to remain in the project (on GitHub) but shouldn't be in your PR.
If you included the file as a deletion in your PR, it could cause issues.
You can use chatGPT to see how you can remove this file from the PR. If you find you are stuck, let me know and I can give you more instructions on how to revert these changes!
The package-lock.json file shouldn't be included in the PR either.
|
I usually stage and commit my changes in GitHub. I didn’t include these
files. This sprint has been really difficult—there were a lot of issues
with the files, changes, and problems in VS Code. The next two sprints in
The Data grousp module are already completed, but I’m stuck on this one
because of all the errors and technical issues in the editor.
…On Sat, Jul 19, 2025 at 2:22 AM Jennifer Alexander ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I think there might be a bit of confusion regarding the package.json and
package-lock.json files.
When I asked you to remove them from the PR, it seems you may have thought
I asked you to "remove" the file from the project completely.
The file needs to *remain* in the project (on GitHub) but shouldn't be in
your PR.
If you included the file as a deletion in your PR, it could cause issues.
You can use chatGPT to see how you can remove this file from the PR. If
you find you are stuck, let me know and I can give you more instructions on
how to revert these changes!
The package-lock.json file shouldn't be included in the PR either.
Screenshot.2025-07-18.at.8.10.01.PM.png (view on web)
<https://github.com/user-attachments/assets/42e8b1f2-b5fe-40ce-b269-9d90a055f370>
—
Reply to this email directly, view it on GitHub
<#634 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L23JS5A53EU24P6ILT3JGMWLAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZVGA2DMMJTG4>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/review/3035046137
@github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
Self checklist
Changelist
All the issues have been solved in Sprint 3